Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go-consistent #47

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Add go-consistent #47

merged 1 commit into from
Mar 5, 2020

Conversation

jlwt90
Copy link
Contributor

@jlwt90 jlwt90 commented Feb 16, 2020

Background

Try to add go-consistent support to reviewdog
Related issue: quasilyte/go-consistent#33

PS: I am not the author of go-consistent. That's why I would also request review from the author too.

Error format

The input file is generated by the test data.
The line generating this log is from here. Since there is no configuration file, there should be only one error format.

@mgrachev mgrachev merged commit e3defe1 into reviewdog:master Mar 5, 2020
@mgrachev
Copy link
Member

mgrachev commented Mar 5, 2020

@jlwt90 👋Thank you for your contribution! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants